Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN release documentation update #82

Merged
merged 16 commits into from
Jul 31, 2024
Merged

CRAN release documentation update #82

merged 16 commits into from
Jul 31, 2024

Conversation

rammprasad
Copy link
Collaborator

Documentation updates

closes #81

@rammprasad rammprasad linked an issue Jul 31, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 31, 2024

Code Coverage

Package Line Rate Health
sdtm.oak 93%
Summary 93% (953 / 1021)

@rammprasad
Copy link
Collaborator Author

@ramiromagno @galachad - This PR is ready for your review. Let's merge it before we create the release candidate. If there are any pipeline errors, please feel free to fix them.

Copy link
Collaborator

@ramiromagno ramiromagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rammprasad and @galachad: I've made a few changes:

  • Whitelisted some acronyms that got introduced with the new docs
  • Fixed the VignetteIndexEntry value to match the vignette title in study_sdtm_spec.Rmd
  • Fixed the Slack URL that was incomplete in README.md
  • Added my name and affiliation to the authors' section to pkgdown configuration for side nav bar hyperlinking
  • Rerun current package state in linux, macos, macos-arm64, windows VMs with rhub which seems to be passing fine.

NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@galachad galachad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NEWS.md Show resolved Hide resolved
@rammprasad rammprasad merged commit a8fde23 into main Jul 31, 2024
13 checks passed
@rammprasad rammprasad deleted the 81-cran-doc-updates branch July 31, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

CRAn Release Documentation Updates
5 participants